Skip to content

fix #1550: add deprection warning #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2020
Merged

fix #1550: add deprection warning #1551

merged 2 commits into from
May 20, 2020

Conversation

teklakct
Copy link
Contributor

Add deprecation notice for wrapper.is() method with couple examples how it could be replaced.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:
    Improvie documentation

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Add deprecation notice for `wrapper.is()` method with couple examples how it could be replaced.
Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Suggested a minor tweak.

thanks for this!

Co-authored-by: Adrià Fontcuberta <[email protected]>
@lmiller1990 lmiller1990 merged commit e5b0f00 into vuejs:dev May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants