-
Notifications
You must be signed in to change notification settings - Fork 668
chore: fix typos #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix typos #1533
Conversation
@@ -428,7 +428,7 @@ export default class Wrapper implements BaseWrapper { | |||
overview(): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overview()
function uses isVisible()
in L439.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind... overview
is deprecated as well. I was just confused because I recently saw the function implemented for the first time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this deprecation?
If people find it very useful, I guess we can keep it - the idea was to thin down the API and really focus on providing a clean experience there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently working on my first real project with Vue. Without a lot of experience, you stumble across a number of hurdles when testing. For this, the method was helpful a few times, even if it was never part of my final tests. I used it for debugging purposes.
Up to this point I would surely have done it without this method. I think to make a decision you would have to ask various other people.
Limiting the API to the bare minimum is definitely a good decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch.fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Improve deprecation messages.