Skip to content

chore: fix typos #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2020
Merged

chore: fix typos #1533

merged 3 commits into from
May 6, 2020

Conversation

lmiller1990
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Improve deprecation messages.

@@ -428,7 +428,7 @@ export default class Wrapper implements BaseWrapper {
overview(): void {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overview() function uses isVisible() in L439.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind... overview is deprecated as well. I was just confused because I recently saw the function implemented for the first time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this deprecation?

If people find it very useful, I guess we can keep it - the idea was to thin down the API and really focus on providing a clean experience there.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently working on my first real project with Vue. Without a lot of experience, you stumble across a number of hurdles when testing. For this, the method was helpful a few times, even if it was never part of my final tests. I used it for debugging purposes.

Up to this point I would surely have done it without this method. I think to make a decision you would have to ask various other people.

Limiting the API to the bare minimum is definitely a good decision.

Copy link

@maxarndt maxarndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmiller1990 lmiller1990 merged commit 17d336e into dev May 6, 2020
@lmiller1990 lmiller1990 deleted the fix-typos branch May 6, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants