Skip to content

Updated the Using nextTick section #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2020
Merged

Conversation

bhaskar-nair2
Copy link
Contributor

@bhaskar-nair2 bhaskar-nair2 commented Mar 20, 2020

  1. The currrent description for Using nextTick was very confusing for a beginner so updated that for easier understanding.
  2. The example provided for nextTick would have not worked unless the user would import Vue (which had not been stated anywhere so far, nor was necessary) so made changes for the example to work with wrapper.vm.$nextTick().

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

1. The currrent description for Using `nextTick` was very confusing for a beginner so updated that for easier understanding.
2. The example provided for `nextTick` would have not worked unless the user would `import Vue` (which had not been stated anywhere so far, nor was necessary) so made changes for the example to work with `wrapper.vm.$nextTick()`.
Lint edit on line 139
@JessicaSachs
Copy link
Collaborator

Nice. Thank you for this.

Context: @bhaskar-nair2 and I spoke in Vue Land's testing channel after he read the docs and needed additional context on what/why nextTick was needed.

This helps users who are visiting the docs/VTU for the first time understand WHY and WHEN they will need nextTick.

@JessicaSachs JessicaSachs merged commit 4657d16 into vuejs:dev Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants