-
Notifications
You must be signed in to change notification settings - Fork 668
Respect provide from parentComponent #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff9c8a1
to
205acf8
Compare
Hey @xanf, thanks for picking up another PR 💯. Unfortunately, the 3-4 of the specs are currently failing. Do you have time to take a look at the branch and work through the error message? Cheers. |
@JessicaSachs Sure, I'll update this one this week |
Hi @xanf! any chance you could take a look at this? :) |
I'm facing this same issue :( Is there any progress with this guy? |
I don't thnk so. @jdmerinor are you interested in picking this one up by any chance? I have a bunch of other things I need to work (v3 integration, v1 release...) |
Everything is passing locally for me 🤔 I will resolve the conflicts and run the test on CI again. |
Ok, code is fine - just one of the older versions of Vue has some compat issues with 2.1x. For some reason this is breaking
|
Ok so oddly enough this is the problem 🤔 |
Passing! Thanks for the contribution @xanf ! |
Instead of replacing
parentComponent
provide - merge it, so we canprovide
values in parentComponent section of configFixes #1262