Skip to content

Respect provide from parentComponent #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2020

Conversation

xanf
Copy link
Contributor

@xanf xanf commented Sep 3, 2019

Instead of replacing parentComponent provide - merge it, so we can provide values in parentComponent section of config

Fixes #1262

@xanf xanf force-pushed the respect-provide-from-parent branch from ff9c8a1 to 205acf8 Compare September 3, 2019 11:20
@xanf xanf changed the title Respect provide from parent Respect provide from parentComponent Sep 3, 2019
@JessicaSachs
Copy link
Collaborator

Hey @xanf, thanks for picking up another PR 💯. Unfortunately, the 3-4 of the specs are currently failing. Do you have time to take a look at the branch and work through the error message? Cheers.

@xanf
Copy link
Contributor Author

xanf commented Dec 18, 2019

@JessicaSachs Sure, I'll update this one this week

@afontcu
Copy link
Member

afontcu commented Feb 18, 2020

Hi @xanf! any chance you could take a look at this? :)

@jdmerinor
Copy link

I'm facing this same issue :( Is there any progress with this guy?

@lmiller1990
Copy link
Member

I don't thnk so. @jdmerinor are you interested in picking this one up by any chance? I have a bunch of other things I need to work (v3 integration, v1 release...)

@lmiller1990
Copy link
Member

lmiller1990 commented Apr 7, 2020

Everything is passing locally for me 🤔

I will resolve the conflicts and run the test on CI again.

@lmiller1990
Copy link
Member

lmiller1990 commented Apr 7, 2020

Ok, code is fine - just one of the older versions of Vue has some compat issues with 2.1x. For some reason this is breaking setMethods on shallowMount in 2.1... wtf?

it('should replace methods when tied to an event', () => {
fails ONLY only for Vue 2.1 - seems no have no relation to the code changes here though?

@lmiller1990
Copy link
Member

@lmiller1990
Copy link
Member

lmiller1990 commented Apr 7, 2020

Passing!

Thanks for the contribution @xanf !

@lmiller1990 lmiller1990 self-requested a review April 7, 2020 14:00
@lmiller1990 lmiller1990 merged commit 351f573 into vuejs:dev Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parentComponent does not provide values
5 participants