Skip to content

docs: update key event example #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2019
Merged

docs: update key event example #1165

merged 1 commit into from
Mar 3, 2019

Conversation

eostrom
Copy link
Contributor

@eostrom eostrom commented Mar 2, 2019

event.which is deprecated and (at least in recent Chrome) can't be set, which made the example test fail. event.key works.

Closes #1162.

@eostrom
docs: update key event example
38788fe 
`event.which` is deprecated and (at least in recent Chrome) can't be
set, which made the example test fail. `event.key` works.

Closes vuejs#1162.
eddyerburgh
eddyerburgh approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@eddyerburgh eddyerburgh merged commit 4cc79e1 into vuejs:dev Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eostrom @eddyerburgh