Skip to content

Fix the file names referenced in comments #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fix the file names referenced in comments #1090

merged 1 commit into from
Jan 9, 2019

Conversation

nlitwin
Copy link
Contributor

@nlitwin nlitwin commented Jan 8, 2019 •
edited
Loading

The test file example references the following import:

import storeConfig from './store-config'

but the code example that is imported calls itself store-config.spec.js instead of store-config.js.

  • Fix the file reference in the comment of the JS file
  • Add a file reference to the spec file

eddyerburgh
eddyerburgh approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@eddyerburgh eddyerburgh merged commit 2dee66c into vuejs:dev Jan 9, 2019
@nlitwin nlitwin deleted the patch-1 branch January 9, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlitwin @eddyerburgh