data should be function

[trollepierre]

Version

1.0.0-beta.20

Reproduction link

vue-test-utils/test/specs/mounting-options/localVue.spec.js

Line 20 in 1ee03ac

data: { test: '' }

Steps to reproduce

Open this:

vue-test-utils/test/specs/mounting-options/localVue.spec.js

Line 20 in 1ee03ac

data: { test: '' }

 data: { test: '' } 

should be written as

data: () => ({ test: '' })

What is expected?

data: () => ({ test: '' })

What is actually happening?

data: { test: '' }

---

https://vuejs.org/v2/guide/components.html#data-Must-Be-a-Function

[eddyerburgh]

Would you like to open a PR to make the change?

[Mardoxx]

Does it have to be a function?

https://vuejs.org/v2/examples/

new Vue({
  el: '#editor',
  data: {
    input: '# hello'
  },
  computed: {
    compiledMarkdown: function () {
      return marked(this.input, { sanitize: true })
    }
  },
  methods: {
    update: _.debounce(function (e) {
      this.input = e.target.value
    }, 300)
  }
})

E: Ahh I see this is a simple example which isn't a reusable component... makes sense. 😄

[eddyerburgh]

It doesn't have to be, no. ~~The test works correctly, although it will log a warning in the latest vue version~~ I was wrong about this. The test fails when data is a function

…

On Wed, 4 Jul 2018, 12:54 Mardoxx, ***@***.***> wrote: Does it have to be a function? https://vuejs.org/v2/examples/ new Vue({ el: '#editor', data: { input: '# hello' }, computed: { compiledMarkdown: function () { return marked(this.input, { sanitize: true }) } }, methods: { update: _.debounce(function (e) { this.input = e.target.value }, 300) } }) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#797 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMlbW7AcLdpxHXHH5h0PBF44EHXfB0TXks5uDKzqgaJpZM4VBBS5> .