-
Notifications
You must be signed in to change notification settings - Fork 668
Initial TODOs #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
(added checkboxes to track progress) |
@codebryo @LinusBorg Is anyone working on the typings? I could probably help there if not, just let me know! |
@snaptopixel No, would be great if you could make a PR 😄 If you do, please follow the new commit convention - https://github.com/vuejs/vue/blob/dev/.github/COMMIT_CONVENTION.md |
Are we ready to publish a Beta of the library? Someone already has vue-test-utils on npm, should we reach out and see if we could get that package spot or rename this repo to one we can get on npm |
@yyx990803 has already been in touch with the author. I'm happy to publish a beta once it becomes available |
@eddyerburgh do we have a gitbook for the docs under development already? I would like to get started on that, and add a bunch of examples. |
There isn't a gitbook that it's hooked up to, but the /docs directory is in the format requried for a gitbook. It even has a It would be great for you to start working on it 👍 |
@snaptopixel we still need typings, and I haven't got much experience with typescript. Are you still willing to add them? |
Hi Jason, we do have the name, but since we haven't released the original
package is still on npm. I understand this is causing confusion and hope to
release asap
…On 20 Jul 2017 23:11, "Jason Aller" ***@***.***> wrote:
Ensure that the name vue-test-utils is available on npm. Either get
https://www.npmjs.com/package/vue-test-utils ->
https://github.com/holmescn/vue-test-utils to hand over the name, or pick
an alternative project name that isn't already claimed to eliminate long
term confusion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMlbW9HtwKsMIDGsN5mf5pJy2OXiKF2_ks5sP9B9gaJpZM4NxDwB>
.
|
@eddyerburgh for the typings do you have something in mind other than http://definitelytyped.org/guides/contributing.html for how you want that done? |
@jraller The types are already added, but if there's anything missing please make a PR 😄 |
I just found https://github.com/vuejs/vue-test-utils/tree/master/types and am looking at it now. This renders all of my existing comments rather moot. |
Hey hey, any word on publishing? |
Hi Austin,
There are a few things holding us up. Evan has been busy lately, and I'm on
vacation at the moment. There are also a couple of issues the need to be
sorted before publishing - mainly how find and findAll work.
…On Thu, Aug 10, 2017 at 3:05 PM, Austin ***@***.***> wrote:
Hey hey, any word on publishing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMlbW9JjPnTT2t0ItxNpoFX8lh9W7rhSks5sWw4OgaJpZM4NxDwB>
.
|
Sweet, thanks for update and enjoy vacation, i can probably clear some room to knock out this week if there is consensus |
Just checking in since it's bit a little over a month, any updates on publishing? |
Evan's reviewing the code this week and we're planning to publish a beta on npm |
The todos are complete, and beta is released 🚀 |
I copied over the TODOs from #1 (comment) so it's not necessary to hunt them down in the long thread.
TODOs
Add shallow methodAdd emit method? In the proposal this is included in trigger, but it's difficult(impossible?) to implement. Not sure if this is needed, as it will be a thin wrapper around vm.$emit.Won't be added in first version,See API for testing emitted events #6Add option to stub componentsFinalize VueWrapper interface. Should it call methods on all wrappers, or default to first wrapper?Using find and findAllAdd context option to support functional components seePassing context to functional components #12Test find and findAll using functional component with contextAdd flowAdd typescript typesHandle empty WrapperArray method callsHandle ErrorWrapper method callsFix some skipped tests copied from avoriazadd deploy scriptUpdate docs format to follow Vue docs styleImprove docs, especially info on WrapperArrayImprove build pipeline. Should dist be included in the source repo?Add CI tool - travis/ circleAdd provide option to mountAdd way to add global mixins/plugins/components without polluting global Vue. See Stop Vue.use polluting global Vue instance #2Add ability to test emitted events - although this can be acheived withWon't be added in first version, See API for testing emitted events #6wrapper.vm.$on('event', spy)
.Add option to pass component as stub, see Stubbing components #11Add release scriptStub registered global components when runningshallow
Throw an error about running in a browser ifwindow
is undefinedAdd git pre commit hooks to check commit message matches guidelinesImprove error messages (errors should have format - [vue-test-utils]: error message)Add option to pass array to options.stubAdd children option to pass children to functional componentsSet default branch to devRemovenpm postinstall
from master/ release branchesCreate example projects and link in READMEUpdate mount and shallow arguments in documentationThe text was updated successfully, but these errors were encountered: