Setting showDeprecationWarnings to false does not hide attachToDocument deprecation warnings.

[phiter]

Version

1.0.0

Reproduction link

vue-test-utils/packages/shared/validate-options.js

Lines 36 to 40 in 44ac570

	if ('attachToDocument' in options) {
	warn(
	`options.attachToDocument is deprecated in favor of options.attachTo and will be removed in a future release`
	)
	}

Steps to reproduce

1. Configure test utils to not show deprecation warnings using config.showDeprecationWarnings = false;
2. Set attachToDocument to true in one of your mount functions.
3. Run tests and check console.

What is expected?

Deprecation warnings should not be shown

What is actually happening?

They are showing

---

I didn't make a reproduction repository because the error is simple and I linked the exact line with the issue above. That line should use warnDeprecated instead of warn.

There should also be a unit test to cover attachToDocument. I noticed that there is a single test to check if this config works.

vue-test-utils/test/specs/config.spec.js

Lines 104 to 117 in 44ac570

	it('allows control deprecation warnings visibility', () => {
	config.showDeprecationWarnings = true
	const Component = {
	name: 'Foo',
	template: '<div>Foo</div>'
	}
	const wrapper = mountingMethod(Component)
	wrapper.name()
	expect(console.error).to.be.calledWith(sandbox.match('name is deprecated'))
	config.showDeprecationWarnings = false
	wrapper.name()
	expect(console.error).to.have.callCount(1)
	})
	})

[lmiller1990]

Thanks. I will tackle these deprecation warnings this weekend. We definitely did not handle this well or thoroughly enough.

I will also make the PR template less annoying, not every issue needs a repro.

[phiter]

@lmiller1990 I have fixed it already in my PR but I can't get the test working, can you check it?

[lmiller1990]

This will go out in the next few days

[lmiller1990]

It's out https://github.com/vuejs/vue-test-utils/releases/tag/v1.0.3