Skip to content

provide/inject in composition api components #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Stoom opened this issue Nov 22, 2019 · 3 comments
Closed

provide/inject in composition api components #1355

Stoom opened this issue Nov 22, 2019 · 3 comments

Comments

@Stoom
Copy link
Contributor

Stoom commented Nov 22, 2019

Version

1.0.0-beta.29

Reproduction link

N/A

Steps to reproduce

Mount a composition api component that uses injection

What is expected?

The injection to be resolved

What is actually happening?

The injection is unknown

This is an ABI issue. In the Composition API component it is looking for the provider under vm._provided whereas a Vue 2.x component is looking for it under vm.provide
@Stoom
Copy link
Contributor Author

Stoom commented Nov 22, 2019

Fixed in PR #1354

@JessicaSachs
Copy link
Collaborator

Hey @Stoom! Thank you for your PR and issue report. As soon as you make the changes, we'll merge it into the dev branch. 🙇‍♀

@Stoom
Copy link
Contributor Author

Stoom commented Dec 18, 2019

#1354 merged

@Stoom Stoom closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JessicaSachs @Stoom