fix: Adjust router.go to fire navigation guards #3252
Conversation
| @@ -167,6 +167,7 @@ beforeRouteLeave (to, from, next) { | |||
| 7. Call `beforeRouteEnter` in activated components. | |||
| 8. Call global `beforeResolve` guards. | |||
| 9. Navigation confirmed. | |||
| 1. Call global `onReady` hooks (Only during initial navigation). | |||
There was a problem hiding this comment.
Exact numbering is not required in markdown. Normally to make a numbered list I would just make everything 1. in order to avoid the delta showing all subsequent items in the list as changed. If the team is okay with that, I'll update the numbering accordingly.
There was a problem hiding this comment.
hmm, I don't think it's a good idea calling it inside the runQueue function. I think we should be consistent with how it was before #2292 and call it where updateRoute was called but after ensureURL
No need to update the documentation for this one.
We would also need a test. This one should work as a unit test
|
Thanks for the feedback @posva. I'll work on the requested the changes and add a unit test tonight (PDT). |
|
@sirlancelot Hello! Let me know if you still want to work on this or if you don't mind me taking it |
sirlancelot
force-pushed
the
aftereach-hook-call
branch
from
3bb9985 to
8d30f32
Compare
|
Hi @posva, apologies for the radio silence. I've actually discovered that the real issue has to do with abstract mode's |
sirlancelot
changed the title
|
No worries at all! As you a unit test, since this is only about abstract mode, you can create a new file that instantiates the router in abstract mode, setup an after each, trigger a navigation and check it works. |
|
Fixed in 4da7021 |
Adjust router.go to fire navigation guards when using abstract routing mode.
Close #3250