Skip to content

test: split navigation guards test code into two steps #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2019
Merged

test: split navigation guards test code into two steps #2749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5131d4
test: split navigation guards test code into two steps
zrh122 Apr 26, 2019
92e178a
test: split navigation guards tests
posva May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions test/e2e/specs/navigation-guards.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
module.exports = {
'navigation guards': function (browser) {
// alert commands not available in phantom
if (process.env.PHANTOMJS) {
return
}

'navigation guards with alerts': function (browser) {
browser
.url('http://localhost:8080/navigation-guards/')
.waitForElementVisible('#app', 1000)
.assert.count('li a', 8)
.assert.containsText('.view', 'home')

// alert commands not available in phantom
if (process.env.PHANTOMJS) return

browser
.click('li:nth-child(2) a')
.dismissAlert()
.waitFor(100)
Expand Down Expand Up @@ -63,16 +62,8 @@ module.exports = {
.assert.urlEquals('http://localhost:8080/navigation-guards/foo')
.assert.containsText('.view', 'foo')

.click('li:nth-child(4) a')
.assert.urlEquals('http://localhost:8080/navigation-guards/baz')
.assert.containsText('.view', 'baz (not saved)')
.click('button')
.assert.containsText('.view', 'baz (saved)')
.click('li:nth-child(1) a')
.assert.urlEquals('http://localhost:8080/navigation-guards/')
.assert.containsText('.view', 'home')

// test initial visit
// test initial visit
browser
.url('http://localhost:8080/navigation-guards/foo')
.dismissAlert()
.waitFor(100)
Expand Down Expand Up @@ -100,16 +91,32 @@ module.exports = {
.acceptAlert()
.assert.urlEquals('http://localhost:8080/navigation-guards/bar')
.assert.containsText('.view', 'bar')
},
'navigation guards': function (browser) {
browser
// back to home
.url('http://localhost:8080/navigation-guards/')
.waitForElementVisible('#app', 1000)
.assert.containsText('.view', 'home')

// in-component guard
.click('li:nth-child(4) a')
.assert.urlEquals('http://localhost:8080/navigation-guards/baz')
.assert.containsText('.view', 'baz (not saved)')
.click('button')
.assert.containsText('.view', 'baz (saved)')
.click('li:nth-child(1) a')
.assert.urlEquals('http://localhost:8080/navigation-guards/')
.assert.containsText('.view', 'home')

// in-component guard
.click('li:nth-child(5) a')
.assert.urlEquals('http://localhost:8080/navigation-guards/bar')
.assert.containsText('.view', 'bar')
.assert.urlEquals('http://localhost:8080/navigation-guards/')
.assert.containsText('.view', 'home')
.waitFor(300)
.assert.urlEquals('http://localhost:8080/navigation-guards/qux')
.assert.containsText('.view', 'Qux')

// async component + in-component guard
// async component + in-component guard
.click('li:nth-child(1) a')
.assert.urlEquals('http://localhost:8080/navigation-guards/')
.assert.containsText('.view', 'home')
Expand All @@ -120,7 +127,7 @@ module.exports = {
.assert.urlEquals('http://localhost:8080/navigation-guards/qux-async')
.assert.containsText('.view', 'Qux')

// beforeRouteUpdate
// beforeRouteUpdate
.click('li:nth-child(7) a')
.assert.urlEquals('http://localhost:8080/navigation-guards/quux/1')
.assert.containsText('.view', 'id:1 prevId:0')
Expand Down