Skip to content

fix(router): prevent memory leaks by removing app references from $router.apps once app destroyed (Fixes #2639) #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

fix(router): prevent memory leaks by removing app references from $router.apps once app destroyed (Fixes #2639) #2640

Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4e833a6
fix(router): remove app from $router.apps array once app destroyed (F…
tmorehouse Mar 5, 2019
02eca65
lint
tmorehouse Mar 5, 2019
646c294
lint
tmorehouse Mar 5, 2019
614713a
Update index.js
tmorehouse Mar 30, 2019
c0fd03b
better handling of last app destroyed
tmorehouse Mar 30, 2019
06d0b00
add app destroy testing
tmorehouse Mar 30, 2019
743e0ff
Update api.spec.js
tmorehouse Mar 30, 2019
a90b3f1
Update api.spec.js
tmorehouse Mar 30, 2019
2fe68ca
Update api.spec.js
tmorehouse Mar 30, 2019
44dbc00
Update api.spec.js
tmorehouse Mar 30, 2019
31dad30
Update api.spec.js
tmorehouse Mar 30, 2019
f9d556d
Update api.spec.js
tmorehouse Mar 30, 2019
e724261
Update api.spec.js
tmorehouse Mar 30, 2019
7780df0
Merge pull request #1 from vuejs/dev
tmorehouse Mar 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ export default class VueRouter {

// main app already initialized.
if (this.app) {
app.$once('hook:destroyed', () => {
// Clean out app from this.apps array once destroyed
const index = this.apps.indexOf(app)
if (index > -1) this.apps.splice(index, 1)
})
return
}

Expand Down