Skip to content

docs(ja): migrating from gitbooks #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2018
Merged

docs(ja): migrating from gitbooks #2224

merged 2 commits into from
May 28, 2018

Conversation

nicedaichi3
Copy link
Contributor

This PR islang-ja docs migrating to vuepress

kazupon
kazupon suggested changes May 27, 2018
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/dist/*.js 配下のファイルも更新してしまっているので、それはrevertしてください。 🙏

これらは、リリースされるときにビルドされるものです。

@posva posva added the docs label May 27, 2018
@kazupon kazupon changed the title migrating from gitbooks docs(ja): migrating from gitbooks May 28, 2018
@nicedaichi3
Copy link
Contributor Author

nicedaichi3 commented May 28, 2018 •
edited
Loading

@kazupon
レビューありがとうございます
docs を build したところ更新されていたようでした。
/dist/*.js のファイルを前回のコミットまで revert していますので再度レビューお願いします 🙏

@kazupon kazupon merged commit d849292 into vuejs:dev May 28, 2018
@kazupon
Copy link
Member

kazupon commented May 28, 2018

Thanks!

@nicedaichi3 nicedaichi3 deleted the migration-vuepress-ja branch May 28, 2018 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicedaichi3 @kazupon @posva