Skip to content

change example for apache-config #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2018
Merged

change example for apache-config #2091

merged 2 commits into from
Mar 11, 2018

Conversation

doppelreim
Copy link
Contributor

This is a PR for issue #2090

Instead of using mod_rewrite, it may be possible to use FallbackResource (see https://httpd.apache.org/docs/2.4/mod/mod_dir.html#fallbackresource).
That would be more concise and would not depend on mod_rewrite.

Disclaimer: I just started with vue and am not an expert with apache :)

This is a PR for issue #2090

Instead of using `mod_rewrite`, it may be possible to use `FallbackResource` (see https://httpd.apache.org/docs/2.4/mod/mod_dir.html#fallbackresource).  
That would be more concise and would not depend on `mod_rewrite`.

Disclaimer: I just started with vue and am not an expert with apache :)
@phanan
Copy link
Member

phanan commented Mar 5, 2018

I don't think this is necessary. mod_rewrite is the de-facto standard – can't imagine any Apache installation without it, when FallbackResource requires ^2.4 AFAIK and is arguably much less known. We may add it as a note, which I'm against still, simply because our doc isn't a web server's doc.

@posva
Copy link
Member

posva commented Mar 5, 2018

I was also sceptical about adding it to the dos for the same reason but I think it does help people so often that it is worth having it in the official docs. I personally think a very short note with a clickable link but no code about it is useful. Something along the lines of If you are using Apache ... you can also use FallbackResource

@phanan
Copy link
Member

phanan commented Mar 5, 2018

OK I was wrong. FallbackResource was available before 2.4 :P Still, my point stands that it's a much less known directive.

@doppelreim
Copy link
Contributor Author

I image having any kind of hint would be nice. People just starting out (with vue or developing fullstack in general) would be less likely to trip over that caveat.

Whether that's mod_rewrite or FallbackResource... ultimately, I do not care. Just wanted to give an "fyi" :)

@posva
Copy link
Member

posva commented Mar 5, 2018

I think it's a good FYI, so let's add it as an extra note 😄

@doppelreim
Copy link
Contributor Author

I reverted the example and added an fyi-notice :)

@posva posva merged commit 485d57f into vuejs:dev Mar 11, 2018
posva pushed a commit that referenced this pull request Mar 13, 2018
@doppelreim doppelreim deleted the patch-1 branch March 20, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants