-
-
Notifications
You must be signed in to change notification settings - Fork 5k
Update Japanese docs #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Japanese docs #1813
Conversation
NOTE: pick up from vuejs@7d2e60e
NOTE: pick up from vuejs@b707352
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
遅くなってすみません 🙇
2つコメントしました。
@@ -35,7 +35,7 @@ const router = new VueRouter({ | |||
}) | |||
``` | |||
|
|||
Note that [Navigation Guards](../advanced/navigation-guards.md) are not applied on the route that redirects, only on its target. In the example below, adding a `beforeEnter` or `beforeLeave` guard to the `/a` route would not have any effect. | |||
[ナビゲーションガード](../advanced/navigation-guards.md)はれダイレクトするルートに提供されず、ターゲット上のみに適用されるということに注意してください。例では、`beforeEnter` または `beforeLeave` ガードを `/a` ルートに追加しても効果がありません。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
れダイレクトするルート
👀
@@ -115,17 +115,17 @@ beforeRouteEnter (to, from, next) { | |||
} | |||
``` | |||
|
|||
Note that `beforeRouteEnter` is the only hook that supports passing a callback to `next`. For `beforeRouteUpdate` and `beforeRouteLeave`, `this` is already available, so passing a callback is unnecessary and therefore *not supported*: | |||
`beforeRouteEnter` はコールバックを `next` に渡すことをサポートするだけのフックであるということに注意してください。`beforeRouteUpdate` と `beforeRouteLeave` の場合、 `this` は既に利用可能です。したがって、コールバックを渡す必要はないので、*サポートされません*: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コールバックを
next
に渡すことをサポートするだけのフック
原文はコールバックを渡すことをサポートするのは beforeRouteEnter
だけであることを言ってると思うので、すこし意味が変わってしまっているように見えます。
レビューありがとうございます! |
* docs: http -> https * docs: tweak js string quoting NOTE: pick up from vuejs/vue-router@7d2e60e * docs: pick up from vuejs/vue-router@a5ecfa1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@8f10178 * docs: translate previous commit * docs: pick up from vuejs/vue-router@91f4ad7 * docs: translate previous commit * docs: pick up from vuejs/vue-router@a06e0b2 * docs: translate previous commit * docs: pick up from vuejs/vue-router@3b16bf1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@f0871d1 * docs: translate previous commit * docs: update SUMMARY translation NOTE: pick up from vuejs/vue-router@b707352 * docs: fixed translation mistaking ref: vuejs/vue-router#1813 (comment) * docs: fixed typo
* docs: http -> https * docs: tweak js string quoting NOTE: pick up from vuejs/vue-router@7d2e60e * docs: pick up from vuejs/vue-router@a5ecfa1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@8f10178 * docs: translate previous commit * docs: pick up from vuejs/vue-router@91f4ad7 * docs: translate previous commit * docs: pick up from vuejs/vue-router@a06e0b2 * docs: translate previous commit * docs: pick up from vuejs/vue-router@3b16bf1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@f0871d1 * docs: translate previous commit * docs: update SUMMARY translation NOTE: pick up from vuejs/vue-router@b707352 * docs: fixed translation mistaking ref: vuejs/vue-router#1813 (comment) * docs: fixed typo
* docs: http -> https * docs: tweak js string quoting NOTE: pick up from vuejs/vue-router@7d2e60e * docs: pick up from vuejs/vue-router@a5ecfa1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@8f10178 * docs: translate previous commit * docs: pick up from vuejs/vue-router@91f4ad7 * docs: translate previous commit * docs: pick up from vuejs/vue-router@a06e0b2 * docs: translate previous commit * docs: pick up from vuejs/vue-router@3b16bf1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@f0871d1 * docs: translate previous commit * docs: update SUMMARY translation NOTE: pick up from vuejs/vue-router@b707352 * docs: fixed translation mistaking ref: vuejs/vue-router#1813 (comment) * docs: fixed typo
* docs: http -> https * docs: tweak js string quoting NOTE: pick up from vuejs/vue-router@7d2e60e * docs: pick up from vuejs/vue-router@a5ecfa1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@8f10178 * docs: translate previous commit * docs: pick up from vuejs/vue-router@91f4ad7 * docs: translate previous commit * docs: pick up from vuejs/vue-router@a06e0b2 * docs: translate previous commit * docs: pick up from vuejs/vue-router@3b16bf1 * docs: translate previous commit * docs: pick up from vuejs/vue-router@f0871d1 * docs: translate previous commit * docs: update SUMMARY translation NOTE: pick up from vuejs/vue-router@b707352 * docs: fixed translation mistaking ref: vuejs/vue-router#1813 (comment) * docs: fixed typo
/ping @ktsn