Skip to content

Update Japanese docs #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 23, 2017
Merged

Update Japanese docs #1813

merged 17 commits into from
Oct 23, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Oct 15, 2017

/ping @ktsn

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなってすみません 🙇
2つコメントしました。

@@ -35,7 +35,7 @@ const router = new VueRouter({
})
```

Note that [Navigation Guards](../advanced/navigation-guards.md) are not applied on the route that redirects, only on its target. In the example below, adding a `beforeEnter` or `beforeLeave` guard to the `/a` route would not have any effect.
[ナビゲーションガード](../advanced/navigation-guards.md)はれダイレクトするルートに提供されず、ターゲット上のみに適用されるということに注意してください。例では、`beforeEnter` または `beforeLeave` ガードを `/a` ルートに追加しても効果がありません。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

れダイレクトするルート

👀

@@ -115,17 +115,17 @@ beforeRouteEnter (to, from, next) {
}
```

Note that `beforeRouteEnter` is the only hook that supports passing a callback to `next`. For `beforeRouteUpdate` and `beforeRouteLeave`, `this` is already available, so passing a callback is unnecessary and therefore *not supported*:
`beforeRouteEnter` はコールバックを `next` に渡すことをサポートするだけのフックであるということに注意してください。`beforeRouteUpdate` `beforeRouteLeave` の場合、 `this` は既に利用可能です。したがって、コールバックを渡す必要はないので、*サポートされません*:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コールバックを next に渡すことをサポートするだけのフック

原文はコールバックを渡すことをサポートするのは beforeRouteEnter だけであることを言ってると思うので、すこし意味が変わってしまっているように見えます。

@kazupon
Copy link
Member Author

kazupon commented Oct 23, 2017

レビューありがとうございます!
指摘事項修正しました。:pray:

@kazupon kazupon merged commit 8ee872f into vuejs:dev Oct 23, 2017
@kazupon kazupon deleted the docs/ja branch October 23, 2017 14:40
topstack1226 pushed a commit to topstack1226/hospital-frontend that referenced this pull request Jan 3, 2023
* docs: http -> https

* docs: tweak js string quoting

NOTE:
  pick up from vuejs/vue-router@7d2e60e

* docs: pick up from vuejs/vue-router@a5ecfa1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@8f10178

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@91f4ad7

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@a06e0b2

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@3b16bf1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@f0871d1

* docs: translate previous commit

* docs: update SUMMARY translation

NOTE:
  pick up from vuejs/vue-router@b707352

* docs: fixed translation mistaking

ref: vuejs/vue-router#1813 (comment)

* docs: fixed typo
sphinxDevVic added a commit to sphinxDevVic/vue-router that referenced this pull request Feb 11, 2024
* docs: http -> https

* docs: tweak js string quoting

NOTE:
  pick up from vuejs/vue-router@7d2e60e

* docs: pick up from vuejs/vue-router@a5ecfa1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@8f10178

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@91f4ad7

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@a06e0b2

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@3b16bf1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@f0871d1

* docs: translate previous commit

* docs: update SUMMARY translation

NOTE:
  pick up from vuejs/vue-router@b707352

* docs: fixed translation mistaking

ref: vuejs/vue-router#1813 (comment)

* docs: fixed typo
Luisa-m17 added a commit to Luisa-m17/VueRouter that referenced this pull request Feb 20, 2024
* docs: http -> https

* docs: tweak js string quoting

NOTE:
  pick up from vuejs/vue-router@7d2e60e

* docs: pick up from vuejs/vue-router@a5ecfa1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@8f10178

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@91f4ad7

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@a06e0b2

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@3b16bf1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@f0871d1

* docs: translate previous commit

* docs: update SUMMARY translation

NOTE:
  pick up from vuejs/vue-router@b707352

* docs: fixed translation mistaking

ref: vuejs/vue-router#1813 (comment)

* docs: fixed typo
UltraDEV007 added a commit to UltraDEV007/vue-router that referenced this pull request Apr 26, 2024
* docs: http -> https

* docs: tweak js string quoting

NOTE:
  pick up from vuejs/vue-router@7d2e60e

* docs: pick up from vuejs/vue-router@a5ecfa1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@8f10178

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@91f4ad7

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@a06e0b2

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@3b16bf1

* docs: translate previous commit

* docs: pick up from vuejs/vue-router@f0871d1

* docs: translate previous commit

* docs: update SUMMARY translation

NOTE:
  pick up from vuejs/vue-router@b707352

* docs: fixed translation mistaking

ref: vuejs/vue-router#1813 (comment)

* docs: fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants