Skip to content

[Doc EN]: VueRouter vs. Vue Router // [Doc FR]: Reflect this changes #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2017

Conversation

MachinisteWeb
Copy link
Contributor

@MachinisteWeb MachinisteWeb commented Sep 26, 2017

Hi @posva!

Something goes wrong with essentials/getting-started.md, line 33.

The options are:

If using a module system (e.g. via vue-cli), import `Vue` and `VueRouter` 

Speaking about Class name

or

If using a module system (e.g. via vue-cli), import Vue and Vue Router

Speaking about Product name.

We have chosen to speak about Product name because the real Class syntax is given just after with Vue.use(VueRouter).

I suggest that change in this PR.

What your thoughts about that?

@MachinisteWeb MachinisteWeb changed the title [Doc FR]: Some changes // [Doc EN]: VueRouter vs. Vue Router [Doc EN]: VueRouter vs. Vue Router // [Doc FR]: Reflect this changes Sep 26, 2017
@posva
Copy link
Member

posva commented Sep 26, 2017

You can also say import vue and vue-router because it matches the package name but at the same time you import Vue from 'vue' and import VueRouter from 'vue-router', so I think we can keep it the way it is

@MachinisteWeb
Copy link
Contributor Author

Ok. Maybe that's work in english because of « import » word. I remove my modification for english documentation :) !

Signed-off-by: Bruno Lesieur <[email protected]>
@posva posva merged commit 90bd69e into vuejs:dev Sep 26, 2017
@MachinisteWeb MachinisteWeb deleted the dev branch September 26, 2017 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants