Skip to content

chore: fix invalid type annotation in typings test #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Aug 31, 2017

The current typings test case has invalid type annotation, so the latest TypeScript compiler (v2.4.2) does not pass the test case. I've just fix the annotation to pass the test.

ref #1702

@posva
Copy link
Member

posva commented Aug 31, 2017

@ktsn Thanks 🖖
Do you prefer to wait for someone's else review?

@ktsn
Copy link
Member Author

ktsn commented Aug 31, 2017

@posva No, since it's a tiny fix 😀

@posva posva merged commit 4d4d228 into vuejs:dev Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants