-
-
Notifications
You must be signed in to change notification settings - Fork 5k
feat(router): add 'replaceRoutes' method #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add 'replaceRoutes' method #1603
Conversation
'replaceRoutes' method replaces all routes in router close vuejs#1234
@alekbarszczewski Did you look at CircleCI's log? I just glanced at it and there is one case failing.
|
@nickforddesign yeah I saw it but I don't get it... When I run tests on my computer all tests pass successfuly. I spent some time to figure out why this is happening without any luck. |
Line 13: If CircleCI, use PhantomJS, otherwise use Chrome. So your tests are being executed differently locally than on CircleCI. I am able to get the test to fail locally by changing the config to always use PhantomJS. Sorry I don't have more information, hopefully helps a little in debugging this. |
Please please |
Please can this be fixed up and added...? Need this feature |
Thanks for the PR! After going through an RFC, we are going in a different direction. If you are still interested in implementing this, see #3087 (comment) |
'replaceRoutes' method replaces all routes in router
close #1234