Skip to content

feat(router): add 'replaceRoutes' method #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alekbarszczewski
Copy link

'replaceRoutes' method replaces all routes in router

close #1234

@alekbarszczewski
Copy link
Author

Can someone help me? I don't know why but on my local machine tests are passing while they fail on CircleCI...

screen shot 2017-07-14 at 23 30 02

@nickforddev
Copy link

@alekbarszczewski Did you look at CircleCI's log? I just glanced at it and there is one case failing.

 ✖ Testing if element <.view> contains text: "Route Y".  - expected "Route Y" but got: "Route X"
    at Object.replace routes (/home/ubuntu/vue-router/test/e2e/specs/replace-routes.js:30:15)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

@alekbarszczewski
Copy link
Author

@nickforddesign yeah I saw it but I don't get it... When I run tests on my computer all tests pass successfuly. I spent some time to figure out why this is happening without any luck.

@nickforddev
Copy link

nickforddev commented Aug 2, 2017

https://github.com/vuejs/vue-router/blob/a85c6168e404cea3bd82d5365d7182f1070acbab/test/e2e/runner.js

Line 13: If CircleCI, use PhantomJS, otherwise use Chrome. So your tests are being executed differently locally than on CircleCI.

I am able to get the test to fail locally by changing the config to always use PhantomJS. Sorry I don't have more information, hopefully helps a little in debugging this.

@lightswitch-sa
Copy link

Please please

@rathga
Copy link

rathga commented Apr 20, 2020

Please can this be fixed up and added...? Need this feature

@posva
Copy link
Member

posva commented May 11, 2020

Thanks for the PR! After going through an RFC, we are going in a different direction. If you are still interested in implementing this, see #3087 (comment)

@posva posva closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove existing routes
5 participants