Allow post loaders for template blocks #1328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also sets a default 'lang="html"' query for template blocks.
|
First OSS PR! Tried to follow contributing standards from existing PRs, let me know if I missed anything. |
defnorep
commented
May 28, 2018
| ] | ||
| } | ||
| }, ({ exports }) => { | ||
| expect(exports.staticRenderFns[0].toString()).toContain('Changed!') |
There was a problem hiding this comment.
I'm guessing this is an appropriate test.
|
@yyx990803 Hate to bug you directly, but have you put any thought towards this PR and #1309 ? |
|
Still thinking whether there's a better way about this. Will probably give it some proper thoughts after done with CLI. |
|
Sounds good. I'll maintain the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also sets a default
lang="html"query for template blocks.Potentially resolves #1309