Pull in upstream changes #1289

davidrunger · 2018-05-07T10:59:45Z

No description provided.

…ase-upstream

davidrunger · 2018-05-07T11:15:38Z

I apologize; I had meant to open this PR against my fork. (I think that I've experienced a bug with GitHub's command line tool, hub?) Closing.

While I'm (accidentally) here, though, in case it's useful I'll mention that the reason that my fork exists is because with vuejs/vue-loader I get this error when running node_modules/.bin/webpack:

Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

View full webpack output

❯ node_modules/.bin/webpack
Hash: 05c9541818e1d767118e
Version: webpack 4.7.0
Time: 7894ms
Built at: 2018-05-07 04:11:48
                                                                     Asset       Size                 Chunks             Chunk Names
                                     2c08bb5ee8626b11f096e64fcc18bfb2.webp   24.8 KiB                         [emitted]
      _/assets/images/aa-picture-game-addf2d8db9aae90dce013b39f704ab7b.png   50.1 KiB                         [emitted]
                _/assets/images/david-82bb29909795cbf73a601080f901834f.jpg   28.8 KiB                         [emitted]
                                     d40307b74d73545003cec240fb0bac3b.webp   15.4 KiB                         [emitted]
        _/assets/images/elasticsearch-4c66908c7c3ada3615ef4f064e94bbf9.svg   1.52 KiB                         [emitted]
        _/assets/images/fast_feedback-5bfc589347a1723d78477908eab01bb8.png   25.2 KiB                         [emitted]
                                     ccae78a83c3d3cc825b389db71e540f8.webp   17.2 KiB                         [emitted]
            _/assets/images/groceries-36851f4f346f701d9285b9fb48ef4fb4.jpg   49.3 KiB                         [emitted]
                                     f25721f01a9737cae498287f4c514c13.webp   36.9 KiB                         [emitted]
               _/assets/images/lodash-ce9daa79e777f1f6bb58a40f88c8e09e.svg  448 bytes                         [emitted]
_/assets/images/rc-languages-selector-732ea8a535fecb5d211adce0956a6fbd.png   62.2 KiB                         [emitted]
                                     8ddd2a8d336fb9af6d6472906f292614.webp     54 KiB                         [emitted]
                _/assets/images/rspec-a31c53aef8e5e5b937ebf47815fa4e51.png   2.35 KiB                         [emitted]
                             groceries_initializer-c21e56e0b2be8cc6edac.js   6.21 MiB  groceries_initializer  [emitted]  groceries_initializer
                                          home_app-a9183729506b7f9fc369.js   6.29 MiB               home_app  [emitted]  home_app
                                            styles-a267cec8de32cc3c80b8.js   14.3 KiB                 styles  [emitted]  styles
                                                             manifest.json   1.42 KiB                         [emitted]
Entrypoint groceries_initializer = groceries_initializer-c21e56e0b2be8cc6edac.js
Entrypoint home_app = home_app-a9183729506b7f9fc369.js
Entrypoint styles = styles-a267cec8de32cc3c80b8.js
[./app/assets/stylesheets/styles.scss] 142 bytes {styles} [built] [failed] [1 error]
[./app/assets/stylesheets/vendor/reset.css] 142 bytes {styles} [built] [failed] [1 error]
[./app/javascript/groceries/groceries.vue] 1 KiB {groceries_initializer} [built]
[./app/javascript/groceries/groceries.vue?vue&type=script&lang=js] 498 bytes {groceries_initializer} [built]
[./app/javascript/groceries/groceries.vue?vue&type=style&index=0&id=57db8661&lang=scss&scoped=true] 1020 bytes {groceries_initializer} [built]
[./app/javascript/groceries/groceries.vue?vue&type=template&id=57db8661&scoped=true&lang=pug] 335 bytes {groceries_initializer} [built]
[./app/javascript/groceries/store.js] 4 KiB {groceries_initializer} [built]
[./app/javascript/home/home.vue] 996 bytes {home_app} [built]
[./app/javascript/home/home.vue?vue&type=script&lang=js] 488 bytes {home_app} [built]
[./app/javascript/home/home.vue?vue&type=style&index=0&id=4f733129&lang=scss&scoped=true] 1010 bytes {home_app} [built]
[./app/javascript/home/home.vue?vue&type=template&id=4f733129&scoped=true&lang=pug] 330 bytes {home_app} [built]
[./app/javascript/packs/groceries_initializer.js] 247 bytes {groceries_initializer} [built]
[./app/javascript/packs/home_app.js] 102 bytes {home_app} [built]
[./app/javascript/packs/styles.js] 441 bytes {styles} [built]
[./app/javascript/shared/customized_vue.js] 2.87 KiB {home_app} {groceries_initializer} [built]
    + 288 hidden modules

ERROR in ./app/javascript/home/components/home_section.vue?vue&type=style&index=0&id=e58f21f8&lang=scss&scoped=true (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/home/components/home_section.vue?vue&type=style&index=0&id=e58f21f8&lang=scss&scoped=true)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/home/components/home_section.vue?vue&type=style&index=0&id=e58f21f8&lang=scss&scoped=true 1:0-525 1:541-544 1:546-1068 1:546-1068
 @ ./app/javascript/home/components/home_section.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/home/home.vue?vue&type=script&lang=js
 @ ./app/javascript/home/home.vue?vue&type=script&lang=js
 @ ./app/javascript/home/home.vue
 @ ./app/javascript/packs/home_app.js

ERROR in ./app/assets/stylesheets/styles.scss
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 10:0-25

ERROR in ./app/javascript/groceries/groceries.vue?vue&type=style&index=0&id=57db8661&lang=scss&scoped=true (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/groceries/groceries.vue?vue&type=style&index=0&id=57db8661&lang=scss&scoped=true)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/groceries/groceries.vue?vue&type=style&index=0&id=57db8661&lang=scss&scoped=true 1:0-501 1:517-520 1:522-1020 1:522-1020
 @ ./app/javascript/groceries/groceries.vue
 @ ./app/javascript/packs/groceries_initializer.js

ERROR in ./app/javascript/home/home.vue?vue&type=style&index=0&id=4f733129&lang=scss&scoped=true (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/home/home.vue?vue&type=style&index=0&id=4f733129&lang=scss&scoped=true)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/home/home.vue?vue&type=style&index=0&id=4f733129&lang=scss&scoped=true 1:0-496 1:512-515 1:517-1010 1:517-1010
 @ ./app/javascript/home/home.vue
 @ ./app/javascript/packs/home_app.js

ERROR in ./app/javascript/components/modal.vue?vue&type=style&index=0&id=4d7e1a6c&lang=scss&scoped=true (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/components/modal.vue?vue&type=style&index=0&id=4d7e1a6c&lang=scss&scoped=true)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/components/modal.vue?vue&type=style&index=0&id=4d7e1a6c&lang=scss&scoped=true 1:0-497 1:513-516 1:518-1012 1:518-1012
 @ ./app/javascript/components/modal.vue
 @ ./app/javascript/shared/customized_vue.js
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/basscss-background-colors/css/background-colors.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 4:0-61

ERROR in ./node_modules/basscss/css/basscss.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 3:0-33

ERROR in ./node_modules/basscss-background-images/css/background-images.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 5:0-61

ERROR in ./node_modules/basscss-border-colors/css/border-colors.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 6:0-53

ERROR in ./node_modules/basscss-colors/css/colors.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 7:0-39

ERROR in ./node_modules/basscss-lighten/css/lighten.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 8:0-41

ERROR in ./app/javascript/groceries/components/sidebar.vue?vue&type=style&index=0&id=4269415d&lang=scss&scoped=true (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/groceries/components/sidebar.vue?vue&type=style&index=0&id=4269415d&lang=scss&scoped=true)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/groceries/components/sidebar.vue?vue&type=style&index=0&id=4269415d&lang=scss&scoped=true 1:0-520 1:536-539 1:541-1058 1:541-1058
 @ ./app/javascript/groceries/components/sidebar.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue
 @ ./app/javascript/packs/groceries_initializer.js

ERROR in ./app/javascript/groceries/components/store.vue?vue&type=style&index=0&id=3f952aa2&scoped=true&lang=css (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/groceries/components/store.vue?vue&type=style&index=0&id=3f952aa2&scoped=true&lang=css)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/groceries/components/store.vue?vue&type=style&index=0&id=3f952aa2&scoped=true&lang=css 1:0-517 1:533-536 1:538-1052 1:538-1052
 @ ./app/javascript/groceries/components/store.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue
 @ ./app/javascript/packs/groceries_initializer.js

ERROR in ./app/assets/stylesheets/vendor/reset.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/packs/styles.js 2:0-30

ERROR in ./app/javascript/home/components/skill_row.vue?vue&type=style&index=0&id=0acf5506&scoped=true&lang=css (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/home/components/skill_row.vue?vue&type=style&index=0&id=0acf5506&scoped=true&lang=css)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/home/components/skill_row.vue?vue&type=style&index=0&id=0acf5506&scoped=true&lang=css 1:0-521 1:537-540 1:542-1060 1:542-1060
 @ ./app/javascript/home/components/skill_row.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/home/home.vue?vue&type=script&lang=js
 @ ./app/javascript/home/home.vue?vue&type=script&lang=js
 @ ./app/javascript/home/home.vue
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/base.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 5:0-45
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/button.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 6:0-47
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/card.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 7:0-45
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/dropdown-item.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 8:0-54
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/icon.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 9:0-45
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/input.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 10:0-46
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/menu.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 11:0-45
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/menu-item.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 12:0-50
 @ ./app/javascript/packs/home_app.js

ERROR in ./node_modules/element-ui/lib/theme-chalk/submenu.css
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/shared/customized_vue.js 13:0-48
 @ ./app/javascript/packs/home_app.js

ERROR in ./app/javascript/groceries/components/logged_in_header.vue?vue&type=style&index=0&id=265c86b9&lang=scss&scoped=true (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/groceries/components/logged_in_header.vue?vue&type=style&index=0&id=265c86b9&lang=scss&scoped=true)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/groceries/components/logged_in_header.vue?vue&type=style&index=0&id=265c86b9&lang=scss&scoped=true 1:0-529 1:545-548 1:550-1076 1:550-1076
 @ ./app/javascript/groceries/components/logged_in_header.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/groceries/components/sidebar.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/components/sidebar.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/components/sidebar.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue
 @ ./app/javascript/packs/groceries_initializer.js

ERROR in ./app/javascript/groceries/components/item.vue?vue&type=style&index=0&id=65f37b62&scoped=true&lang=css (./node_modules/style-loader??ref--4-0!./node_modules/css-loader??ref--4-1!./node_modules/vue-loader/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/lib??ref--4-2!./node_modules/sass-loader/lib/loader.js??ref--9-3!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--21!./app/javascript/groceries/components/item.vue?vue&type=style&index=0&id=65f37b62&scoped=true&lang=css)
Module build failed: ValidationError: Style Loader Invalid Options

options['ident'] is an invalid additional property

 @ ./app/javascript/groceries/components/item.vue?vue&type=style&index=0&id=65f37b62&scoped=true&lang=css 1:0-516 1:532-535 1:537-1050 1:537-1050
 @ ./app/javascript/groceries/components/item.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/groceries/components/store.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/components/store.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/components/store.vue
 @ ./node_modules/babel-loader/lib??ref--5-0!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/eslint-loader??ref--12-0!./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue?vue&type=script&lang=js
 @ ./app/javascript/groceries/groceries.vue
 @ ./app/javascript/packs/groceries_initializer.js

~/workspace/david_runger  source-webpacker-via-rubygems ✗ 04:11:48 AM
❯

That error is fixed for me in my fork by changing (vue-)?style-loader to just vue-style-loader in lib/plugin.js here. The problem appears to have been introduced in #1233.

I'm not sure if maybe this is something that only affects me, is something I am doing wrong, and/or which might have negative effects that I am unaware of, though, which is why I hadn't (intentionally) opened a PR here ... only accidentally now. Sorry again, and thanks for all of your work and the wonderful framework that is Vue.js, Evan!

davidrunger added 3 commits April 28, 2018 06:10

Don't reuse ident for style-loader

e7b6b30

15.0.5

cff7b25

Merge branch 'master' of https://github.com/vuejs/vue-loader into reb…

c3a9860

…ase-upstream

davidrunger closed this May 7, 2018

davidrunger deleted the pull-in-upstream-changes branch May 7, 2018 11:15

davidrunger restored the pull-in-upstream-changes branch May 7, 2018 11:22

davidrunger mentioned this pull request May 7, 2018

Pull in upstream changes #1290

Closed

davidrunger deleted the pull-in-upstream-changes branch May 7, 2018 11:42

davidrunger restored the pull-in-upstream-changes branch May 7, 2018 11:42

davidrunger deleted the pull-in-upstream-changes branch May 7, 2018 11:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull in upstream changes #1289

Pull in upstream changes #1289

davidrunger commented May 7, 2018

davidrunger commented May 7, 2018 •

edited

Loading

Pull in upstream changes #1289

Pull in upstream changes #1289

Conversation

davidrunger commented May 7, 2018

davidrunger commented May 7, 2018 • edited Loading

davidrunger commented May 7, 2018 •

edited

Loading