add .d.ts declaration file #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
approved these changes
Mar 27, 2018
| @@ -3,6 +3,7 @@ | |||
| "version": "15.0.0-beta.7", | |||
| "description": "Vue single-file component loader for Webpack", | |||
| "main": "lib/index.js", | |||
| "typings": "lib/index.d.ts", | |||
There was a problem hiding this comment.
Can we change it to types field since looks like types is the recommendation now?
https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html
There was a problem hiding this comment.
I used types before, but I find out typings in vue core package.json and vue-router, should it be consistent here?
There was a problem hiding this comment.
Oh, I see. I guess it's ok to leave as typings then 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable to work with
webpack.config.ts