Skip to content

[docs] updated status of inject-loader (close #892) #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2017
Merged

[docs] updated status of inject-loader (close #892) #1088

merged 1 commit into from
Dec 11, 2017

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Dec 9, 2017

  1. Removed the unstable note about [email protected].
  2. Note for disabling esModule option in inject mode because import/export must be top-level.

Ref: #892

Thanks.


export default {
module.exports = {
data () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ES5, I think you should be change to data: function () {. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it just disables esModule option, not the whole ES6+ syntax. So that's OK imo :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay! :)

@kazupon kazupon merged commit 21809a0 into vuejs:master Dec 11, 2017
@Jinjiang Jinjiang deleted the issue-892 branch December 11, 2017 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants