Fix Error which is braking absolute paths (Issue: #1005) #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo in line 50 leads to an incorrect path submitted to require. Return unchanged url for absolute paths.
|
Works great! Indeed, it fixes issue #1005. Thank you very much, @progressman! |
|
This really solves the issue with srcset attributes. When can we expect this PR to be merged and published on npm? |
LinusBorg
changed the title
|
It seems Evan already fixed it himself, sorry (bcd54d2). I assume he didn't see the PR in the issue because you didn't label it correctly in the PR's title (you forgot the Or do you still see a problem with Evan's implementation? |
|
Ah, sorry I didn't see this PR when I was fixing the issue. Apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in line 50 that leads to an incorrect path submitted to require.
Return unchanged url for absolute paths.