fix: fixed lang='tsx' files not working for vue2-jest
#395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
approved these changes
Oct 8, 2021
| @@ -72,7 +72,7 @@ const getTsJestConfig = function getTsJestConfig(config) { | |||
| const configSet = new ConfigSet(config.config) | |||
| var tsConfig = configSet.typescript || configSet.parsedTsConfig | |||
| return { | |||
| compilerOptions: { ...tsConfig.options, target: 'es5', module: 'commonjs' } | |||
| compilerOptions: { ...tsConfig.options, module: 'commonjs' } | |||
There was a problem hiding this comment.
I wonder if changing the target: 'es5' is going to cause any problems. Let's see if CI passes.
|
I can release over this weekend. Thanks! |
lmiller1990
changed the title
lang='tsx' files not working for vue2-jestlang='tsx' files not working for vue2-jest
|
Forcing an ES5 target isn't ideal for us so I like this change. Do you know when you'll do a release with this in? |
|
Sorry, I forgot to release this. I will try do this within 48h, tag or ping me if it isn't done by the start of next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lang='tsx' files to be transpiled as tsx.
typescript.transpileModuledoes not correctly parse JSX syntax when the file extension is not.tsx.