-
Notifications
You must be signed in to change notification settings - Fork 157
feat: add compile template options #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compile template options #288
Conversation
f947d61
to
37efa58
Compare
Great, sounds good. We can release this week. I wonder if we need something similar for Vue 3 (next branch...) |
@lmiller1990 No idea unfortunately - didn't have time to get a grasp of Vue 3 yet (other than reading through the breaking changes/migration guides 😄 ). It depends if the |
Thanks a lot for this! Was this included in any stable release? I could not find it in the releases tab |
@brunomperes Unfortunately not yet - in my project I've added @lmiller1990 What do you think about releasing new version? |
Oops, sorry! Here we go: https://github.com/vuejs/vue-jest/releases/tag/v4.0.0-rc.1 Not entirely clear where this should transition from RC to a stable 4.0.0. 🤔 |
Thanks! |
I will try to get the Triaging the issues is quite hard, since we have both v4 and v5 here, it's quite confusing. I am not sure how much value there is in triaging old issues - the time is better spent on other things, like merging getting 4.0 and 5.0 stable. For now, I will focus on getting the outstanding PRs merged. Thanks for your help! |
Makes sense. But well, at some point going through left-over issues is a must have - in the best case just to close them 😄 There are lots of issues on this repo and some of them are probably already outdated ;/ |
Fixes #98.
What?
This PR is adding to the
vue-jest
possibility to configure the template compiler used by@vue/component-compiler-utils
package.Why?
By passing correct configuration to the template compiler we can mitigate issues like the #98 - where the problem is directly connected with the proper tool configuration (in this case - the
buble
library).BTW. the graphql case was added in this PR as an e2e test.
Reproduction scenario
The problem can be reproduced by checking out the first commit in this PR and running
yarn test
. Then you'll see this error in the console: