refactor!: support wider range of jest versions by making babel-jest & ts-jest peer dependencies #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& ts-jest peer dependencies It is mainly because ts-jest has a hard-coded jest version requirement. And ts-jest is listed as optional, because not every project needs it.
lmiller1990
approved these changes
Jul 30, 2020
|
@lmiller1990 Could this PR be backported to v4? Because ts-jest has a hard peer dependency on typescript, therefore may cause trouble for non-TS users. |
|
Sure, I can do it this week. PS: can we bump vue-cli to use v4 by default? v3 is not really worked on anymore, I think it's still the default, though. |
|
I will track in here: #281 |
|
Yeah, I plan to bump it in the |
|
Just to confirm - I was talking about making the default for Vue 2 be 4.x. Vue 3 will use 5.x vue-jest 3.x and 4.x are Vue 2 We don't support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is mainly because ts-jest has a hard-coded jest version requirement.
And ts-jest is listed as optional because not every project needs it.