Fix bare imports of Sass files with dots.in.filename.scss #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Sass file attempted to import something like `~module/foo.bar`, our custom resolver would expect `.bar` to be the filetype and would forego appending `.scss` or `.sass`, causing `require.resolve()` to throw an exception. We can be explicit about the filetype by successively testing against `.scss`, `.sass` (depending on configured language in the <style>-bock), and `.css`. Add `.css` support for bare imports, and `.sass` imports from within `.scss` or vice-versa.
vvanpo
changed the title
vvanpo
commented
Jul 29, 2020
| "jest": { | ||
| "moduleNameMapper": { | ||
| "^~foo/(.*)": "<rootDir>/foo/$1", | ||
| // @import '~foo'; -> @import 'path/to/project/foo'; |
There was a problem hiding this comment.
I see that GitHub does not like my usage of comments in a JSON block, fair enough, I'll have to change this to a js block.
There was a problem hiding this comment.
Yep, comments are not valid json. That's why!
lmiller1990
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Great, looks good.
next doesn't even support style loading (at all, yet) so we should look into that sometime. Basically the next branch is the minimal support for Vue 3 SFCs.
This does look good though, thanks! I hope we can port some of these features to next.
|
I will release both a new version for 4.x and 5.x this weekend. |
|
Latest 4.x and 5.x is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #256 (comment).
When importing a Sass file that has dots in its filename but without the
.scssextension (e.g.@import 'foo.bar';), our resolver would assume.barwas the extension and forego appending.scss, causingrequire.resolve()to throw an exception.We need to look for
.scss,.sass, and.cssextensions, as all of these are possible. Previously, it would automatically assume the extension for the file was the same as thelangattribute set on the<style>block, but Sass has no problems importing.sassfrom a.scssfile or vice-versa, and.cssis also very common.