Skip to content

External css #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2019
Merged

External css #158

merged 3 commits into from
Feb 16, 2019

Conversation

hewIngram
Copy link
Contributor

This addresses use of external css files for components as described here: #76

@eddyerburgh not sure how you feel about just writing the external file into stylePart but it seemed like the easiest way of doing this.

@hewIngram hewIngram mentioned this pull request Feb 11, 2019
@eddyerburgh
Copy link
Member

Looks good :)

It's fine to rewrite the content, that's how we do it for script and template.

One small refactor—can you use the loadSrc function. You could move it into lib/utils to use it in both files.

@hewIngram
Copy link
Contributor Author

Ah I totally didn't spot that. 👍
I also renamed filename to filepath as it is the path + more consistent with the rest of the code.

The utils.js file doesn't have unit tests, do you want me to write some or are you happy with the e2e coverage?

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks for this :)

@eddyerburgh
Copy link
Member

The e2e tests are fine

@eddyerburgh eddyerburgh merged commit 630575d into vuejs:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants