Skip to content

Use gzip compression for static assets #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

nolanlawson
Copy link
Contributor

I noticed that the static JS/CSS assets weren't gzipped. Adding Express compression middleware fixes this (while intelligently skipping the HTML since that's chunked and needs to be streamed).

Here's the "before" on a Nexus 5 throttled to 3G; notice the large JS download time:

screenshot 2016-10-23 12 47 48

And here's the "after":

screenshot 2016-10-23 15 49 43

Great work on Vue! Really love the balance between DX and UX; I wrote a bit about it on Twitter. 😃

@yyx990803 yyx990803 merged commit 4b5dc45 into vuejs:master Oct 24, 2016
@yyx990803
Copy link
Member

Thanks for both the PR and the kind words on Twitter :)

@nolanlawson
Copy link
Contributor Author

Thanks for making Vue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants