Skip to content

Fixed incorrect parsing of two hyphens in HTML comments #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2020
Merged

Fixed incorrect parsing of two hyphens in HTML comments #73

merged 1 commit into from
May 14, 2020

Conversation

ota-meshi
Copy link
Member

fixed #72

@ota-meshi ota-meshi force-pushed the issue72 branch 4 times, most recently from c3c8fa1 to 65326a2 Compare May 11, 2020 12:14
@ota-meshi
Copy link
Member Author

In "[email protected]", the parses fails in the eslint test cases.
But I don't know how to fix this successfully. Could you please tell me how to fix it?

@mysticatea
Copy link
Member

I have updated tests for that. Would you update this PR?

@ota-meshi
Copy link
Member Author

@mysticatea Thank you for fixing testcases. It's working fine.

mysticatea
mysticatea approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 6c1ac68 into vuejs:master May 14, 2020
@ota-meshi ota-meshi deleted the issue72 branch May 14, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse the two hyphens in the HTML comment as one hyphen
2 participants
@ota-meshi @mysticatea