Skip to content

fix(unit-jest, unit-mocha): ensure EOL in existing tsconfig.json #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2020
Merged

fix(unit-jest, unit-mocha): ensure EOL in existing tsconfig.json #6006

merged 2 commits into from
Oct 31, 2020

Conversation

ParkerM
Copy link
Contributor

@ParkerM ParkerM commented Oct 25, 2020

Fixes #5948

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

fangbinwei
fangbinwei reviewed Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@fangbinwei fangbinwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems e2e-webdriverio also has this problem. Could you help make them consistent?

@ParkerM
Copy link
Contributor Author

ParkerM commented Oct 28, 2020

It seems e2e-webdriverio also has this problem. Could you help make them consistent?

Good catch, also added it to e2e-webdriverio and re-based onto dev. If I need to update the PR name or squash commits let me know 👍

fangbinwei
fangbinwei approved these changes Oct 31, 2020
View reviewed changes
Copy link
Collaborator

@fangbinwei fangbinwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@fangbinwei fangbinwei merged commit d03169c into vuejs:dev Oct 31, 2020
@ParkerM ParkerM deleted the unit-tsconfig-eol branch October 31, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangbinwei fangbinwei fangbinwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue add unit-mocha removes final newline from tsconfig.json
2 participants
@ParkerM @fangbinwei