refactor!: Switching from Request package to Got

[jeneser]

BREAKING CHANGE: replace Request package with Got

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Underlying tools
• Other, please describe:

Does this PR introduce a breaking change? (check one)

• Yes
• No

Other information:

#5220

[haoqunjiang]

Thanks for the help! But please fix the failing tests. I think the refactored code is not working correctly.

[jeneser]

Oops! There is something wrong with the Yarn. I'm trying to fix it.

[haoqunjiang]

Still failing.
I believe it's due to the usage of .json()

[jeneser]

I don't think so. All test suites are passed on my machine. But, AppVeyor build failed.

FAIL packages/@vue/cli-plugin-eslint/__tests__/eslintMigrator.spec.js
RequestError: connect ECONNREFUSED 127.0.0.1:443

It looks like https-proxy-agent or agent-base break got without even using it. Maybe we need downgrading to got@9, but it would be great to upgrade.

[jeneser]

> npm ls agent-base

/workspace/vue-cli
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected] 
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected] 
├─┬ [email protected]
│ └─┬ @lerna/[email protected]
│   └─┬ @evocateur/[email protected]
│     └─┬ [email protected]
│       ├─┬ [email protected]
│       │ └── [email protected] 
│       └─┬ [email protected]
│         └── [email protected]  deduped
└─┬ [email protected]
  └─┬ [email protected]
    ├─┬ [email protected]
    │ └── [email protected] 
    ├─┬ [email protected]
    │ └── [email protected]  deduped
    └─┬ [email protected]
      └── [email protected]

lerna and lerna-changelog need the latest version. Specifically, make-fetch-happen and agent-base need the latest version.

[haoqunjiang]

I now think we shouldn't use got. Now that it can be interfered with by other packages in the CLI repo, it might also be affected by other global packages installed on the user's machine. We need a safer replacement.

[jeneser]

You are right. The problem is not got fault. agent-base breaks got. But for now, so many packages need an upgrade to the latest version. Maybe that isn't such a great idea.

[jeneser]

Superseded by #6009