refactor(wip): replace node-ipc with a cleanroom IPC implementation #5776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The packet format is compatible with the node-ipc default. After this commit, no core plugins will be using node-ipc to do anything. TODOs: - Finish the IPC server implementation - Refactor `@vue/cli-ui` to get rid of `node-ipc`, too - Fully refactor the IpcMessenger module to address cross-platform issues, etc.
|
Hi @sodatea. Is there any projection on when is this going to be merged? It is so important :) |
|
node-ipc updated to MIT and latest buffer implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packet format is compatible with the
node-ipcdefault.After this commit, no core plugins will rely on
node-ipcto do anything.But the UI still needs it to communicate with plugins.
TODOs:
@vue/cli-uito get rid ofnode-ipc, tooissues, etc.
Fixes #2621
It is a cleanroom implementation because I've never read a line of the
node-ipccode. I've only read the package's README before implementing this PR.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: