Skip to content

添加vue/cli4 sass-loader v9全局注入变量教程 #5656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

添加vue/cli4 sass-loader v9全局注入变量教程 #5656

wants to merge 11 commits into from

Conversation

zxwk1998
Copy link
Contributor

@zxwk1998 zxwk1998 commented Jul 7, 2020 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

haoqunjiang
haoqunjiang previously requested changes Jul 9, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没这么麻烦，只要把 prependData 改个名改成 additionalData 就行了。

@zxwk1998
Copy link
Contributor Author

zxwk1998 commented Jul 9, 2020 •
edited
Loading

大佬可能需要排除对要注入文件的注入，新版不允许重复注入比如原来是a.scss是公共变量文件，直接写的话a.sass头部会注入一次啊a.sass的内容，会报重复，所以要写排除，看下这个项目 你就明白了，你可以把你的想法写在这个项目的vue.config.js上试试，当然也可能是我没找到更好的办法，大佬 有时间可以看一下，希望大佬相信我一次，动手试一下，希望跟您学习
https://github.com/chuzhixin/vue-admin-beautiful

@zxwk1998 zxwk1998 requested a review from haoqunjiang July 9, 2020 13:38
@zxwk1998
Copy link
Contributor Author

zxwk1998 commented Jul 9, 2020

没这么麻烦，只要把 prependData 改个名改成 additionalData 就行了。

请看下这个链接，我还是坚持我的想法，因为我试过直接改不可行
https://github.com/chuzhixin/vue-admin-beautiful/blob/master/vue.config.js

@haoqunjiang haoqunjiang dismissed their stale review July 9, 2020 14:14

确认了一下，确实底层实现有变动。我之前以为只是简单改名了。谢谢指正！

@haoqunjiang
Copy link
Member

另外麻烦把 base branch 改成 master，网站上的文档都是从 master 分支部署的。

@zxwk1998 zxwk1998 changed the base branch from dev to master July 9, 2020 14:18
@zxwk1998
Copy link
Contributor Author

zxwk1998 commented Jul 9, 2020

没这么麻烦，只要把 prependData 改个名改成 additionalData 就行了。

请看下这个链接，我还是坚持我的想法，因为我试过直接改不可行
https://github.com/chuzhixin/vue-admin-beautiful/blob/master/vue.config.js

另外麻烦把 base branch 改成 master，网站上的文档都是从 master 分支部署的。

改好啦 大佬

@zxwk1998 zxwk1998 requested a review from haoqunjiang July 9, 2020 14:30
@zxwk1998
Copy link
Contributor Author

zxwk1998 commented Jul 9, 2020

我又重新推送了一次 总算搞清楚该怎么推送了 大佬见笑了

@haoqunjiang
Copy link
Member

还是有点小问题，你这里把 dev 分支的新提交都带过来了……

@zxwk1998
Copy link
Contributor Author

还是有点小问题，你这里把 dev 分支的新提交都带过来了……
大佬，我重新提了个pull request
#5668
image

@jeneser jeneser mentioned this pull request Jul 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang Awaiting requested review from haoqunjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxwk1998 @haoqunjiang