-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat(e2e-webdriverio): add e2e plugin for WebdriverIO #5479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f8dbb0
to
79d98a8
Compare
Thanks for the pull request! As we are very close to the next scheduled feature release, I'm not able to review such a big piece of code in the next few days. I'll take a look later and hope to fit it into the next feature release (scheduled in June). |
Any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the package-lock.json
file because we use yarn for development.
@sodatea thanks for the review. I updated the PR according to your suggestions. |
@sodatea please let me know if there is anything missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got the time to further review this PR…
Sorry for the delayed response.
Just a few more fixes to get the plugin in better shape.
packages/@vue/cli-plugin-e2e-webdriverio/generator/template/tests/e2e/specs/app.spec.js
Outdated
Show resolved
Hide resolved
packages/@vue/cli-plugin-e2e-webdriverio/generator/template/wdio.local.conf.js
Show resolved
Hide resolved
1365368
to
e1f9a61
Compare
@sodatea thanks for the review. I addressed the comments and also added WebdriverIO to the docs (english only). The build is failing due to connectivity issues, let's rerun them. |
Seems the build isn't failing because of network issues. But somehow yarn cannot resolve the vue-cli/packages/@vue/cli-plugin-e2e-nightwatch/package.json Lines 31 to 32 in d319007
(I will update them in a batch later, so don't mind the chrome version being too old) |
@sodatea thanks for the tip. Looks all good now. |
Thanks! |
What kind of change does this PR introduce? (check at least one)
This PR adds a new e2e option to run tests using WebdriverIO:
I am happy to be help triaging and fixing all issues that users might create using this plugin. I am the WebdriverIO maintainer and invested in the usability of this.
Does this PR introduce a breaking change? (check one)
Other information: