Skip to content

docs: fix readme of @vue/cli-plugin-eslint #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020
Merged

docs: fix readme of @vue/cli-plugin-eslint #5226

merged 1 commit into from
Feb 28, 2020

Conversation

noi
Copy link
Contributor

@noi noi commented Feb 27, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

The default target directories of vue-cli-service lint command was written as src and test, but I think that src and tests are correct. If my opinion is correct, please merge.

Related code here:

config.ignorePattern = [
'!.*.js',
'!{src,tests}/**/.*.js'
]
}
const engine = new CLIEngine(config)
const defaultFilesToLint = [
'src',
'tests',
// root config files
'*.js',
'.*.js'
]

The default target directories of `vue-cli-service lint` command was written as `src` and `test`, but `src` and `tests` are correct.
@noi noi changed the base branch from dev to master February 27, 2020 15:32
@noi
Copy link
Contributor Author

noi commented Feb 28, 2020

The checks passed, but github returns an error and remains pending. Can anyone please confirm it?

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@haoqunjiang haoqunjiang merged commit 0569054 into vuejs:master Feb 28, 2020
@noi noi deleted the fix-eslint-readme branch February 28, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants