Skip to content

chore: Minor typographical fix #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2020
Merged

chore: Minor typographical fix #5189

merged 2 commits into from
Feb 16, 2020

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Feb 15, 2020 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe: Fixed a typo.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
N/A

@jamesgeorge007 jamesgeorge007 requested review from haoqunjiang and removed request for haoqunjiang February 15, 2020 10:11
@jamesgeorge007 jamesgeorge007 changed the title chore(deps): update memfs chore: Minor typographical fix Feb 15, 2020
@jamesgeorge007 jamesgeorge007 force-pushed the feat/update-dep branch 2 times, most recently from 0b76fa2 to e82efa8 Compare February 15, 2020 10:17
haoqunjiang
haoqunjiang previously approved these changes Feb 16, 2020
View reviewed changes
@haoqunjiang haoqunjiang self-requested a review February 16, 2020 05:41
@haoqunjiang haoqunjiang dismissed their stale review February 16, 2020 05:42

tests are failing

haoqunjiang
haoqunjiang requested changes Feb 16, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests too.

haoqunjiang
haoqunjiang requested changes Feb 16, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing one test.

@haoqunjiang haoqunjiang merged commit 1423553 into vuejs:dev Feb 16, 2020
@jamesgeorge007 jamesgeorge007 deleted the feat/update-dep branch February 16, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesgeorge007 @haoqunjiang