Skip to content

refactor: check support package manager befor install #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

refactor: check support package manager befor install #3368

merged 1 commit into from
Jan 28, 2019

Conversation

musicq
Copy link
Contributor

@musicq musicq commented Jan 25, 2019

refactor

if (command === 'npm') {
    ...
} else if (command === 'yarn') {
    ...
} else {
    throw new Error('...')
}

to

checkPackageManagerIsSupported(command)

if (command === 'npm') {
    ...
} else if (command === 'yarn') {
    ...
}

@haoqunjiang haoqunjiang merged commit 5d1ab5f into vuejs:dev Jan 28, 2019
@carlosrojaso carlosrojaso mentioned this pull request Oct 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@musicq @kazupon @haoqunjiang