Skip to content

fix(cli-ui): folder list when root windows #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

fix(cli-ui): folder list when root windows #3331

merged 1 commit into from
Jan 21, 2019

Conversation

jtommy
Copy link
Contributor

@jtommy jtommy commented Jan 20, 2019

Issue: #3253

It's a node issue on Windows when using drive path without backslash.

@haoqunjiang
Copy link
Member

haoqunjiang commented Jan 21, 2019 •
edited
Loading

Sidenote:
According to nodejs/node-v0.x-archive#4688 It's not a bug of node. A more accurate fix is to ensure the argument passed to list has an following path seperator. Nonetheless, it's an acceptable fix.

@haoqunjiang haoqunjiang merged commit d047aca into vuejs:dev Jan 21, 2019
@haoqunjiang haoqunjiang mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtommy @haoqunjiang @Akryum