Skip to content

fix(vue-ui): enforce package.json npm rules #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2019
Merged

fix(vue-ui): enforce package.json npm rules #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce5c92c
fix(vue-ui): convert project name to lowercase
hamedbaatour Jan 2, 2019
212f208
fix(vue-ui): enforce package.json name rules
hamedbaatour Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@vue/cli-ui/apollo-server/connectors/projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ async function create (input, context) {

const inCurrent = input.folder === '.'
const name = inCurrent ? path.relative('../', process.cwd()) : input.folder
creator.name = name
creator.name = name.toLowerCase()

// Answers
const answers = prompts.getAnswers()
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-ui/src/util/folders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export function isValidName (name) {
return !name.match(/[/@\s+%:]/) && encodeURIComponent(name) === name
return !name.match(/[/@\s+%:]|^[_.]/) && encodeURIComponent(name) === name && name.length <= 214
}

export function isValidMultiName (name) {
Expand Down