fix(cli-service): do not log absolute baseUrl in terminal, close #2877 #2900
Conversation
| @@ -89,7 +90,7 @@ module.exports = (api, options) => { | |||
| protocol, | |||
| host, | |||
| port, | |||
| options.baseUrl | |||
| isAbsoluteUrl(options.baseUrl) ? '/' : options.baseUrl | |||
There was a problem hiding this comment.
Won't that break for baseUrl: http://localhost:8081/someBasePath/ ?
There was a problem hiding this comment.
Set baseUrl to http://localhost:8081/someBasePath/ doesn't mean to start the dev-server on localhost:8081, the dev-server would still be started on ${host}:${port}.
There was a problem hiding this comment.
Sure, but doesn't the console now say " go to host: port/" even though people would have to go to "localhost:port/baseurl"?
I'm honestly confused because paths and hosts in webpack can be confusing as hell to me
There was a problem hiding this comment.
Consider those two cases here:
-
Asset files (js/css/img) are served by
webpack-dev-server(eg. localhost:8080), and user uses a reverse proxy to access the html (eg. localhost:3000/app/). In this case,baseUrlshould be set tohttp://localhost:8080/, but user need to openhttp://localhost:3000/app/in browser. -
Asset files (js/css/img) are served by
webpack-dev-server(eg. localhost:8080), and user uses a reverse proxy to access the asset files (eg. localhost:3000/assets/). In this case,baseUrlshould be set tohttp://localhost:3000/assets/, and user need to go tohttp://localhsot:8080in browser.
What I want to say is, we cannot infer which url should user open in browser if user set baseUrl to a absolute url. What we can do is tell user "we have started your dev-server on localhost:8080"...
And, yes it is confusing. 😂
There was a problem hiding this comment.
Awesome, that was very helpful. Thanks.
#2877