fix(serve): also detect kubernetes containers #2795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a Vue CLI 3 server / container template for CodeSandbox and having an HMR issue (an invalid webpack socket URL), looking at how HMR is configured in
serve.js
, I've noticed thatserve
should be detecting that it's running in a container, but it's not. Looking further at the container detection code, and then at/proc/1/cgroup
inside the container, it looks like, so I added
kubepods
to the detection regex.You can see it working at https://codesandbox.io/s/qv463kv6z6 (where I manually changed
serve.js
insidenode_modules/@vue/cli-service
).The "access the dev server via http://localhost..." message is still a bit confusing, I could add CodeSandbox container detection if desired (@Akryum: I pinged you on Vue Discord, maybe we can discuss this further there).