Skip to content

After project has created the spinner continue to rotate on header and terminal stack on "Generating README.md..." #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VladimirCores opened this issue Mar 3, 2020 · 1 comment · Fixed by #5493
Closed

After project has created the spinner continue to rotate on header and terminal stack on "Generating README.md..." #5240

VladimirCores opened this issue Mar 3, 2020 · 1 comment · Fixed by #5493
Labels
scope: ui

Comments

@VladimirCores
Copy link

Version

4.2.2

Reproduction link

https://mega.nz/#!lksyHAYB!b2t7D9X_b7dpjWLQg3Bdy6A38j0CfR2TQmrSwBqpjjk

Environment info

System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
  Binaries:
    Node: 11.0.0 - ~/.nvm/versions/node/v11.0.0/bin/node
    Yarn: Not Found
    npm: 6.9.0 - ~/.nvm/versions/node/v11.0.0/bin/npm
  Browsers:
    Chrome: 80.0.3987.122
    Firefox: Not Found
    Safari: 13.0.5
  npmPackages:
    @storybook/vue: ^5.0.3 => 5.0.3 
    vue-vimeo-player: 0.0.9 => 0.0.9 
  npmGlobalPackages:
    @vue/cli: 4.2.2

Steps to reproduce

Start new project with custom settings

What is expected?

Project setup complete

What is actually happening?

Looks like it is not

Link with screenshot: https://mega.nz/#!lksyHAYB!b2t7D9X_b7dpjWLQg3Bdy6A38j0CfR2TQmrSwBqpjjk
@haoqunjiang
Copy link
Member

Project setup does have completed. There's a bug that we mistakenly output the log to the console, it should be shown in the UI and cleared after project creation.

haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this issue May 16, 2020
@haoqunjiang
fix(ui): the logs from creator should be displayed in the UI
9586eb8 
With `logWithSpinner`, the log would be output to the console instead.

Fixes vuejs#5240
Fixes vuejs#5445
@haoqunjiang haoqunjiang mentioned this issue May 16, 2020
Merged
9 tasks
haoqunjiang added a commit that referenced this issue May 18, 2020
@haoqunjiang
fix(ui): the logs from creator should be displayed in the UI (#5493)
90f1146 
With `logWithSpinner`, the log would be output to the console instead.

Fixes #5240
Fixes #5445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): the logs from creator should be displayed in the UI haoqunjiang/vue-cli
2 participants
@VladimirCores @haoqunjiang