Skip to content

Choosing to save as a preset should also tell you where it was saved #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
revolter opened this issue Feb 19, 2020 · 2 comments · Fixed by #5212
Closed

Choosing to save as a preset should also tell you where it was saved #5197

revolter opened this issue Feb 19, 2020 · 2 comments · Fixed by #5212
Labels
contribution welcome enhancement good first issue

Comments

@revolter
Copy link

What problem does this feature solve?

  • Run vue create my-app
  • Choose to save it as a preset

The output that comes after this last question looks identical to the one where you choose not to save it as a preset.

What does the proposed API look like?

I expected for a "The preset was saved to ~/.vuerc" log to be present.
@imrishabh18
Copy link

Hey, I am a beginner can i work on this issue ?

jaireina pushed a commit to jaireina/vue-cli that referenced this issue Feb 24, 2020
feat(vue-cli): Choosing to save as a preset tells you where it is saved
c0cbb30 
close vuejs#5197
@jaireina jaireina mentioned this issue Feb 24, 2020
Merged
9 tasks
@jaireina
Copy link
Contributor

@sodatea I created a pull request for you to check when you have time.

haoqunjiang pushed a commit that referenced this issue Mar 21, 2020
@jaireina
feat(vue-cli): Choosing to save as a preset tells you where it is sav…
e5449ad 
…ed (#5212)

close #5197

Co-authored-by: Jair Reina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(vue-cli): Choosing to save as a preset tells you where it is saved jaireina/vue-cli
4 participants
@jaireina @haoqunjiang @revolter @imrishabh18