(Hopefully) Complete PWA support (fixes #769, #771) #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chrisvfritz
changed the title
|
👍 Looks good to me. By the way, I found some compatibility issues between hexo-offline (JLHwung/hexo-offline#21) and hexo 3.3. I would investigate later and likely do a fix release in couple days. It is not a big deal as this project is fixing hexo version to 3.2. The hexo-offline Thank you @morigs @chrisvfritz for your great effort on PWA support. |
|
@JLHwung Thanks for the review and the warning. We'd like to get back to latest eventually, but 3.2 is the last version that doesn't seem to produce an error for anyone in the community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off work done earlier by @morigs and @JLHwung, this PR includes:
@morigs and @JLHwung, I'd love a review to confirm that this looks good to you.