Skip to content

Add is attribute to API, fixes #804 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2017

Conversation

chrisvfritz
Copy link
Contributor

@chrisvfritz chrisvfritz commented May 20, 2017

Anything else I miss here?

@chrisvfritz chrisvfritz changed the title Add is attribute to API Add is attribute to API, fixes #804 May 20, 2017
@chrisvfritz chrisvfritz requested review from kazupon and znck May 20, 2017 15:00
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@znck znck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@znck
Copy link
Member

znck commented May 20, 2017

This is not required in single file components.

It should be mentioned, I guess.

@chrisvfritz
Copy link
Contributor Author

@znck Hmm, if someone isn't sure what's meant by "in-DOM templates", that section gives a little more information on the exact cases one has to worry about, so I think we're covered. This is something that's good to think about though and if someone opens up an issue because they were confused, we can clarify further. 🙂 👍

@chrisvfritz chrisvfritz merged commit 57ebc78 into vuejs:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants