Fix broken transition example #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padding is set to `0 !important`, so this example didn't work. It's also bad practice to transition padding unless you really have to: in this case, a transform is more performant, so I changed it to that instead.
|
Will this need fixing on the other repos too, or are they completely different docs? Happy to send more PRs once this change has been approved. |
|
I believe this is the only version of the docs with this specific example. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding is set to
0 !important, so this example didn't work. It's alsobad practice to transition padding unless you really have to: in this
case, a transform is more performant, so I changed it to that instead.