Skip to content

Remove Vue School Summer Sale banner #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Remove Vue School Summer Sale banner #2842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e41ae3
Remove Vue School Summer Sale banner
nicodevs Jun 25, 2021
a6a6753
Remove Vue School banner images
nicodevs Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions themes/vue/layout/index.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,10 @@
})

window.addEventListener('scroll', function () {
var offset = 20
if (window.pageYOffset > offset && !topScrolled) {
if (window.pageYOffset > 165 && !topScrolled) {
topScrolled = true
document.getElementById('mobile-bar').classList.remove('top')
} else if (window.pageYOffset <= offset && topScrolled) {
} else if (window.pageYOffset <= 165 && topScrolled) {
topScrolled = false
document.getElementById('mobile-bar').classList.add('top')
}
Expand Down
4 changes: 2 additions & 2 deletions themes/vue/layout/layout.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% var isIndex = page.path === 'index.html' %>
<% var isThemes = page.path === 'resources/themes.html' %>
<% var hasVueSchoolBanner = true %>
<% var hasVueSchoolBanner = false %>

<!DOCTYPE html>
<html lang="en" class="with-v3-banner">
Expand Down Expand Up @@ -55,7 +55,7 @@
<link href="https://fonts.gstatic.com" rel="preconnect" crossorigin>
<link href="https://maxcdn.bootstrapcdn.com" rel="preconnect" crossorigin>

<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto|Roboto Mono&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto Mono&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css?family=Dosis:500&text=Vue.js&display=swap" rel="stylesheet">

<link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" rel="stylesheet">
Expand Down
1 change: 0 additions & 1 deletion themes/vue/source/css/_header.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ body.docs
display: none
box-shadow: 0 0 2px rgba(0,0,0,.25)
pointer-events: none
transition: background-color 0.25s ease-in
> *
pointer-events: auto
.menu-button
Expand Down
1 change: 0 additions & 1 deletion themes/vue/source/css/index.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
@import "_sponsors-index"
@import "_modal"
@import "_themes"
@import "_vueschool.styl"

$width = 900px
$space = 40px
Expand Down
1 change: 0 additions & 1 deletion themes/vue/source/css/page.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
@import "_scrimba"
@import "_vue-mastery"
@import "_themes"
@import "_vueschool.styl"

#header
box-shadow: 0 0 1px rgba(0,0,0,.25)
Expand Down
7 changes: 0 additions & 7 deletions themes/vue/source/images/banners/close.svg
View file
Open in desktop

This file was deleted.

Binary file removed themes/vue/source/images/banners/vs-backpack.png
View file
Open in desktop
Binary file not shown.
13 changes: 0 additions & 13 deletions themes/vue/source/images/banners/vs-iso.svg
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions themes/vue/source/images/banners/vs-logo.svg
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions themes/vue/source/js/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
initMobileMenu()
initVideoModal()
initNewNavLinks()
initVueSchoolBanner()
if (PAGE_TYPE) {
initVersionSelect()
initApiSpecLinks()
Expand Down Expand Up @@ -441,7 +440,7 @@
if(dataTypeAttr && dataTypeAttr.nodeValue === 'theme-product-title') {
return 300
}
return localStorage.getItem('VS_SUMMER_BANNER_CLOSED') ? 0 : 80
return 0
}
})
}
Expand Down