Skip to content

Document gotcha with :is and DOM props #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Document gotcha with :is and DOM props #2402

merged 1 commit into from
Dec 1, 2019

Conversation

ferk6a
Copy link
Contributor

@ferk6a ferk6a commented Nov 25, 2019

This is #2241 reborn. The motivation for it is that this snippet of code:

<component :is="multiline ? 'textarea' : 'input'" v-model="value">

Won't work as would expect, so we are documenting that you should, instead, use :value.prop and @input instead of v-model.

@phanan
Copy link
Member

phanan commented Nov 26, 2019

Pinging @sdras as she's been involved with the other from day 1.

@sdras
Copy link
Member

sdras commented Dec 1, 2019

perfect, thank you for resubmitting!

@sdras sdras merged commit 3d96b74 into vuejs:master Dec 1, 2019
@vue-bot
Copy link
Contributor

vue-bot commented Dec 1, 2019

Thanks again! 💚

@ferk6a
Copy link
Contributor Author

ferk6a commented Dec 2, 2019

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants